T5-T6, Ferrata ignored?

Tom · March 15, 2021, 7:01pm

Hey,
I have another question.
Are ways with traildifficulty > 4 ignored in building the graph?
Also it seems that waytype ferrata is ignored in building the graphs too.
Is it possible to activate both when building the graph by editing the options?

Example:
https://classic-maps.openrouteservice.org/directions?n1=47.342196&n2=11.515024&n3=16&a=47.344464,11.516697,47.344552,11.515775,null,null&b=2&c=0&k1=de&k2=km

amandus · March 16, 2021, 9:57am

Hi @Tom,

trail difficulty is generated from the sac scale:

sac scales abov 4 are considered rather difficult:

It is not possible to activate them during the build process. The information is saved in the graph, but the logic to use them is defined in the flagencoders:

github.com

GIScience/openrouteservice/blob/30c1137762009283bc590ec49d35a30f0a9a409f/openrouteservice/src/main/java/org/heigit/ors/routing/graphhopper/extensions/flagencoders/HikingFlagEncoder.java

/*
 * This file is part of Openrouteservice.
 *
 * Openrouteservice is free software; you can redistribute it and/or modify it under the terms of the
 * GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1
 * of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
 * without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 * See the GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License along with this library;
 * if not, see <https://www.gnu.org/licenses/>.
 */

package org.heigit.ors.routing.graphhopper.extensions.flagencoders;

import com.graphhopper.util.PMap;

import java.util.Arrays;

This file has been truncated. show original

See issue:

github.com/GIScience/openrouteservice

Router fails to route over a mountain on a hiking path

opened 04:34PM - 11 Oct 19 UTC

Philipp-M

enhancement | feature

on hold :hand:

I'm not sure if this is the right place, but this seems to be some kind of bug. … #### Here's what I did Tried to create a hiking route, but the router doesn't do what I wan't to do (doesn't route me over the mountain, no matter how hard I try). --- #### Here's what I got Here is a link, where I think it is obvious what I tried to do: https://maps.openrouteservice.org/directions?n1=47.40625&n2=11.466336&n3=14&a=47.439917,11.265728,47.452353,11.351624,47.421061,11.428699,47.411187,11.437669,47.410469,11.434568,47.409684,11.434429,47.40959,11.434128,47.376093,11.424408,47.286049,11.4&b=2b&c=0&k1=en-US&k2=km --- #### Here's what I was expecting As I said, i'd like to get over the mountain, and don't want to walk an extra tour. --- #### Here's what I think could be improved Maybe the tour is too hard for the router, in this case, probably an extra option to enable via ferrata hiking might be helpful.

Best regards

Tom · March 16, 2021, 10:50am

Thanks for the information.
I read all these issues and threads before, but did not get an answer to my question from these.

So if i edit the file HikingFlagEncoder.java
and add lines to get:

suitableSacScales.addAll(Arrays.asList(
                "hiking",
                "mountain_hiking",
                "demanding_mountain_hiking",
                "alpine_hiking",
                "demanding_alpine_hiking",
                "difficult_alpine_hiking",
        ));

        preferredWayTags.addAll(Arrays.asList(
                "track",
                "path",
                "footway",
                "via_ferrata"
        ));

Does routing work for me after restart the web app or do i have to build graphs again?

Tom · March 31, 2021, 3:18pm

I have tried it now.
Stopped Docker.
Changed the HikingFlagEncoder.java.
Start the Docker via Compose.
But does still not route demanding_alpine_hiking ways.
Can you approve this?

amandus · April 1, 2021, 9:38am

Hi Tom,

Could you add the request that you tried?
Did you try it with the correct profile (foot-hiking)?

Another approach would be to adjust this function:

github.com

GIScience/openrouteservice/blob/104371bb60298f90641908a1d11e3e6a6325eace/openrouteservice/src/main/java/org/heigit/ors/routing/graphhopper/extensions/flagencoders/FootFlagEncoder.java#L319-L328


 * Determine if the way is seen as being too difficult based on any sac_scale tags and the information provided in
 * the setup of the object (suitableSacScales)
 *
 * @param way   The way to be assessed
 * @return      Whether the way is too difficult or not
 */
private boolean hasTooDifficultSacScale(ReaderWay way) {
    String sacScale = way.getTag(OSMTags.Keys.SAC_SCALE);
    return sacScale != null && !suitableSacScales.contains(sacScale);
}

to always return false.
Then you should come to the same result as adding the remaining sac scales.

Best regards

Tom · April 1, 2021, 10:26am

Thank you.

I have changed this function to return always false.
But routing still does not work on Ways >T4.
The file was in: var/lib/docker/overlay2/af6fe7d1ae1c37cb72c21c673c77b11cd5fbf7d90fd6fb50c0b52d5f619e87b9/diff/ors-core/openrouteservice/src/main/java/org/heigit/ors/routing/graphhopper/extensions/flagencoders/FootFlagEncoder.java
Is this the right path for the file? It is the only file on my server with this name.
Can i debug somehow if the change is working?

jschnell · April 13, 2021, 12:14pm

Hey Tom,

as far as I’m aware, the docker container doesn’t rebuild the code on restarting with docker-compose -
try docker-compose build --no-cache ors-app to make sure it rebuilds.
I’m also unsure whether the graphs have to be rebuilt when changing stuff in the encoders…

As for testing whether it’s working, I’d suggest logging something in the function in question - that should at least give you some feedback to whether you are running the code you should be running

Best regards,
Jakob

jschnell · April 14, 2021, 12:26pm

A post was split to a new topic: Problem with building ors-app with docker

Tom · April 14, 2021, 3:32pm

I am running the ors-app with changed function.
But seems not to route T5+.
How can i log if the function is doing like i want?

Currently i am running graphs for europe, so testing is too long to wait for.
Tomorrow i will give it a try and rebuild the graphs for the alps with the changed function.
Maybe i have more luck this way.

Tom · April 15, 2021, 7:50am

It works!
If someone is interested here is how it works for me: (with docker-compose)

Go into your docker directory where ORS is running.
cd ORS (for example)
docker-compose down (stop and delete ors-app)
docker-compose pull (download newest version of ors-app)

Now locate FootFlagEncoder.java file in your docker.
Should be in var/lib/docker/overlay2/
Edit FootFlagEncoder.java about line 325 the function private boolean

hasTooDifficultSacScale(ReaderWay way)
Change: return sacScale != null && !suitableSacScales.contains(sacScale);
to: return false; //sacScale != null && !suitableSacScales.contains(sacScale);

Save the file.

Now delete the graphs folder.
And now rebuild graphs with
docker-compose up -d

In my case ORS is now routing T5+ too!

Thx for supporting me to get there!

Tom · April 19, 2021, 1:01pm

Addtional:

Now i got to run highway=via_ferrata too!
Even though the via_ferratas are not show on the OSM Standard map, as you can see here:

But you can route nevertheless to this path.

Just find the file FootFlagEncoder.java
and edit about line 130. Add the line “via_ferrata” to the given array

allowedHighwayTags.addAll(Arrays.asList(
                "cycleway",
                "unclassified",
                "road",
                "via_ferrata"
        ));

Then delete graphs folder an build graph again.

amandus · April 19, 2021, 1:06pm

Hi @Tom,

i’m happy that it worked out for you!

Just make sure to inform the users of your App of the waydifficulty

Tom · April 19, 2021, 1:09pm

Of course i do so.
For T5-T6 there is an text “extreme difficult” and an additional exclamation mark sign!
I am working on via_ferrata now, because there is no sac_scale but special via_ferrata_scale what you do not offer as extra_info.